Skip to content

Dark sidebar when dark theme selected #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nicm42 wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Dark sidebar when dark theme selected #164

nicm42 wants to merge 5 commits into from

Conversation

@nicm42
Copy link

@nicm42 nicm42 commented Apr 22, 2021

Description

Updated navbar styles so sidebar appears in dark theme colours when dark theme is selected, and stays in light theme colours when light theme is selected.

Motivation and Context

Addresses item 5 in #135
People using dark mode will no longer be blinded by the sidebar

How Has This Been Tested?

I ran the navbar styles test.
I did manual testing in dark and light mode.

Screenshots (if appropriate):

dark
light

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 22, 2021 •
edited
Loading

Codecov Report

Merging #164 (98820f8) into development (a7affeb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           development      #164   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              285       285           
  Lines             3178      3188   +10     
  Branches           584       586    +2     
=============================================
+ Hits              3178      3188   +10
Impacted Files Coverage Δ
.../display/views/help/components/AboutTrackerPane.js 100.00% <ø> (ø)
src/display/shared/columns/threads/LastPoster.js 100.00% <100.00%> (ø)
.../display/views/threads/components/CheckboxTable.js 100.00% <100.00%> (ø)
...rc/display/views/threads/components/_getTdProps.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7691747...98820f8. Read the comment docs.

@blackjackkent
Copy link
Owner

blackjackkent commented Apr 23, 2021

Hey! Thank you so much for this contribution! This looks great!

One thing - the border color on the right side of the sidebar in the dark theme now looks a little too bright. Can we maybe change that border to the GRAY_400 color constant, while keeping the light theme border GRAY_200?

Other than that, this is awesome; once that's changed, I can get it merged in. 🚀

@blackjackkent blackjackkent mentioned this pull request Apr 23, 2021
Open
@nicm42
Copy link
Author

nicm42 commented Apr 23, 2021

I've made that change. It does look better in dark mode with that border less bright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicm42 @blackjackkent